This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Updated repos and added changes for Xcode 10.2 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiMoskvin
previously approved these changes
Apr 5, 2019
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| VVPSDK.swift | 0.00% |
💀 |
| Player_VideoEvents.swift | 0.00% |
💀 |
| PropsMapping.swift | 3.36% |
💀 |
| Metrics.swift | 55.31% |
|
| Telemetry.swift | 56.76% |
Powered by xcov
Generated by 🚫 Danger
balavor
force-pushed
the
updates-to-remove-warnings
branch
from
10a568d
to
f02dfc6
Compare
balavor
force-pushed
the
updates-to-remove-warnings
branch
from
f02dfc6
to
e3c751d
Compare
|
@RomanTysiachnik any updates here? |
balavor
force-pushed
the
updates-to-remove-warnings
branch
from
3774d20
to
fc02fce
Compare
|
Should be merged as we have failing tutorials, that use old version of SDK that is not working on Xcode 10.2 |
AndriiMoskvin
previously approved these changes
Apr 11, 2019
balavor
force-pushed
the
updates-to-remove-warnings
branch
from
fc02fce
to
ab2435a
Compare
AndriiMoskvin
approved these changes
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@VerizonAdPlatforms/video-partner-sdk-developers: Please review.