This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Updated item controller with wrapper handling #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladyslavAnokhin
force-pushed
the
OMSDK-2015/wrapper-processing
branch
from
91d125a
to
359e9e9
Compare
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| VVPSDK.swift | 0.00% |
💀 |
| VRMItemController.swift | 91.67% |
✅ |
Powered by xcov
Generated by 🚫 Danger
VladyslavAnokhin
force-pushed
the
OMSDK-2015/wrapper-processing
branch
2 times, most recently
from
6105956
to
5771f21
Compare
AndriiMoskvin
previously requested changes
Jan 14, 2019
| @@ -406,12 +406,13 @@ public struct VVPSDK { | |||
| } | |||
|
|
|||
| func setupVRMWithNewCore() { | |||
| let maxRedirectCount = 2 | |||
There was a problem hiding this comment.
Have to be put this on M/S side - make necessary arrangements on client side.
There was a problem hiding this comment.
It's separate task, will do this in other PR.
VladyslavAnokhin
force-pushed
the
OMSDK-2015/wrapper-processing
branch
from
5771f21
to
10cae55
Compare
AndriiMoskvin
approved these changes
Jan 14, 2019
balavor
approved these changes
Jan 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Item controller dispatches action
TooManyIndirectionsif set of processing candidates contains more thanmaxRedirectCountitemsJIRA Ticket
@OathAdPlatforms/mobile-sdk-developers: Please review.