This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
CPM implementation #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AndriiMoskvin
commented
Dec 17, 2018
AndriiMoskvin
commented
- Tracking Pixels update with CPM value
- Logic wiring
AndriiMoskvin
force-pushed
the
OMSDK-2024/cpm-implementation
branch
2 times, most recently
from
5207045
to
aa208cf
Compare
Current coverage for OathVideoPartnerSDK.framework is
|
| Files changed | - | - |
|---|---|---|
| TrackingPixelsConnector_Ad.swift | 0.00% |
💀 |
| TrackingPixelsGenerator.swift | 0.00% |
💀 |
| TrackingPixelsReporter.swift | 0.00% |
💀 |
| AdVRMEngine.swift | 2.17% |
💀 |
| VRMProvider.swift | 22.22% |
💀 |
| AdURLProvider.swift | 88.60% |
✅ |
Current coverage for PlayerCore.framework is 53.70%
✅ No files affecting coverage found
Powered by xcov
Generated by 🚫 Danger
AndriiMoskvin
force-pushed
the
OMSDK-2024/cpm-implementation
branch
from
aa208cf
to
8827325
Compare
VladyslavAnokhin
approved these changes
Dec 19, 2018
balavor
reviewed
Dec 19, 2018
| api = YAML.load(File.read(path)).map { |request_name, fields| | ||
| file = nil | ||
| Dir.chdir('..') do | ||
| path = "mobile-sdk-evolution/definitions/tracking pixels/tracking-pixels.yaml" |
There was a problem hiding this comment.
Is it possible to avoid the hardcoded path to mobile-sdk-evolution as far as it is not a part of this SDK anymore?
There was a problem hiding this comment.
Maybe - it is temporary solution.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.