This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Tutorials + changelog update #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| Thumbnail+VideoProviderResponse.swift | 0.00% |
💀 |
| SkipAd.swift | 0.00% |
💀 |
| VRMCoreVASTModel.swift | 22.73% |
💀 |
| VRMParsingResult.swift | 28.12% |
🚫 |
| AdVRMManager.swift | 34.55% |
🚫 |
| VRMFinalResult.swift | 36.00% |
🚫 |
| AdCreative.swift | 36.49% |
🚫 |
| Rate.swift | 36.97% |
🚫 |
| Ad.swift | 38.89% |
🚫 |
| ScheduledVRMItems.swift | 43.48% |
🚫 |
| AdKill.swift | 47.06% |
🚫 |
| VRMItemResponseTime.swift | 48.24% |
🚫 |
| VPAIDErrors.swift | 50.00% |
|
| VRMFetchItemQueue.swift | 53.12% |
|
| VRMParseItemQueue.swift | 53.33% |
|
| VPAIDState.swift | 53.95% |
|
| PlaybackBuffering.swift | 54.55% |
|
| Duration.swift | 54.84% |
|
| OpenMeasurement_Tracking.swift | 56.25% |
|
| AdFinishTracker.swift | 58.82% |
|
| OpenMeasurement.swift | 60.00% |
|
| VRMProcessingResult.swift | 60.00% |
|
| VRMGroupsQueue.swift | 61.54% |
|
| Progress.swift | 63.89% |
|
| Mute.swift | 64.29% |
|
| CurrentTime.swift | 65.57% |
|
| VRMTimeoutActionsCreator.swift | 66.67% |
|
| VRMResponse.swift | 66.67% |
|
| VRMProcessingTimeout.swift | 69.23% |
|
| VRMRequestStatus.swift | 70.00% |
|
| VRMCurrentGroup.swift | 72.73% |
|
| VRMTopPriorityItem.swift | 75.00% |
|
| VRMMaxAdSearchTimeout.swift | 77.78% |
|
| LoadedTimeRanges.swift | 80.00% |
✅ |
| VRMFetchingError.swift | 80.00% |
✅ |
| VRMOtherError.swift | 80.00% |
✅ |
| VRMParsingError.swift | 80.00% |
✅ |
| VRMRedirectError.swift | 80.00% |
✅ |
| VRMTimeoutError.swift | 80.00% |
✅ |
| PlaybackModel.swift | 80.00% |
✅ |
| PlayAd.swift | 81.67% |
✅ |
| PlaybackStatus.swift | 88.89% |
✅ |
| State.swift | 99.29% |
✅ |
| VRMResponseModel.swift | 100.00% |
✅ |
| RendererDescriptor.swift | 100.00% |
✅ |
| AdVASTModel.swift | 100.00% |
✅ |
| AdPixels.swift | 100.00% |
✅ |
| VRMItemActions.swift | 100.00% |
✅ |
| VRMCoreItemSchedulingActionCreator.swift | 100.00% |
✅ |
| VRMCoreResultSelectionActionCreator.swift | 100.00% |
✅ |
| AdVRMManager_Hashable.swift | 100.00% |
✅ |
| InteractiveSeeking.swift | 100.00% |
✅ |
Current coverage for VerizonVideoPartnerSDK.framework is 36.82%
| Files changed | - | - |
|---|---|---|
| VASTModel.swift | 0.00% |
💀 |
| Player_VideoEvents.swift | 0.00% |
💀 |
| Context.swift | 0.00% |
💀 |
| PlayerViewController.swift | 0.00% |
💀 |
| PlayerViewController_Binding.swift | 0.00% |
💀 |
| PlayerViewController_Clickthrough.swift | 0.00% |
💀 |
| JavaScriptObserver.swift | 0.00% |
💀 |
| PropsMapping.swift | 0.00% |
💀 |
| AdMaxShowTimeDetector.swift | 0.00% |
💀 |
| AdSkipDetector.swift | 0.00% |
💀 |
| VideoSelector.swift | 0.00% |
💀 |
| TrackingPixelsConnector_Ad.swift | 0.00% |
💀 |
| VVPSDK.swift | 0.00% |
💀 |
| VRMRequestDetector.swift | 0.00% |
💀 |
| OpenMeasurementContext.swift | 0.00% |
💀 |
| TrackingPixelsConnector.swift | 0.00% |
💀 |
| AdVRMEngine.swift | 1.10% |
💀 |
| PlayerInterface.swift | 6.31% |
💀 |
| VRMProvider.swift | 12.50% |
💀 |
| PlayerProperties.swift | 25.00% |
🚫 |
| StartVRMGroupProcessingController.swift | 30.00% |
🚫 |
| MaxAdSearchTimeController.swift | 37.50% |
🚫 |
| FinishVRMGroupProcessingController.swift | 38.46% |
🚫 |
| Metrics.swift | 46.15% |
🚫 |
| AdURLProviderProcess.swift | 50.00% |
|
| VVPSDK_Version.swift | 50.00% |
|
| VPAIDAdCreativeController.swift | 50.00% |
|
| AdMetrics.swift | 50.00% |
|
| AdEngineRequestDetector.swift | 55.56% |
|
| MP4AdCreativeController.swift | 57.14% |
|
| VRMSelectFinalResultController.swift | 65.00% |
|
| ParseVRMItemController.swift | 65.85% |
|
| VRMMidrollProcessorController.swift | 67.65% |
|
| Dictionary+ParseJSON.swift | 71.05% |
|
| VRMTimeoutController.swift | 75.00% |
|
| AdEngineResponseDetector.swift | 78.57% |
|
| VRMProcessingController.swift | 80.49% |
✅ |
| MidrollDetector.swift | 84.48% |
✅ |
| VRMItemController.swift | 85.71% |
✅ |
| FetchVRMItemController.swift | 87.50% |
✅ |
| PlayerProperties_Init.swift | 87.96% |
✅ |
| AdURLProvider.swift | 88.60% |
✅ |
| Store.swift | 91.67% |
✅ |
| Observer.swift | 95.24% |
✅ |
| VRMRequestController.swift | 96.63% |
✅ |
| VASTParser.swift | 99.53% |
✅ |
| VideoProviderResponse.swift | 100.00% |
✅ |
| VASTParser_Offset.swift | 100.00% |
✅ |
| VideoProviderParsing.swift | 100.00% |
✅ |
| OpenMeasurementController.swift | 100.00% |
✅ |
| AdManagerPresenter.swift | 100.00% |
✅ |
| SlotOpportunityDetector.swift | 100.00% |
✅ |
| AdPlaybackCycleDetector.swift | 100.00% |
✅ |
| AdViewTimeDetector.swift | 100.00% |
✅ |
Powered by xcov
Generated by 🚫 Danger
balavor
approved these changes
Feb 16, 2019
VladyslavAnokhin
previously approved these changes
Feb 18, 2019
|
Please, wait for the next release. |
AndriiMoskvin
dismissed stale reviews from VladyslavAnokhin and balavor
via
dd4c5d5
AndriiMoskvin
force-pushed
the
OMSDK-2666/tutorials+changelog-update
branch
from
227d90f
to
dd4c5d5
Compare
|
@VladyslavAnokhin @RomanTysiachnik RFR. |
VladyslavAnokhin
approved these changes
Feb 20, 2019
balavor
approved these changes
Feb 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@VerizonAdPlatforms/video-partner-sdk-developers: Please review.