New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lodash from dependencies #249
Conversation
What was the reason for removing lodash? |
@redonkulus sorry, my fault. The main reason is bundle size. In the end, even with the specific function imports that were being used, ~25kb of lodash was still flowing into a bundle with fetchr. Here is the fluxible todo app example with and without fetchr: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the picker changes are well tested
@redonkulus Could we have a release of this one? |
@pablopalacios fetchr@0.5.42 is published now |
And it's live in our systems, working like a charm ;). |
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.