modified according to comments and added deprecation

yahoo · Sep 6, 2016 · cac8388 · cac8388
1 parent a1ee775
commit cac8388
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,20 +12,27 @@ Current
 
 -  [QueryTimeLookup Functionality Testing](https://github.com/yahoo/fili/pull/34)
     * Added two tests `LookupDimensionFilteringDataServeletSpec` and `LookupDimensionGroupingDataServletSpec` to test QTL functionality
-    * Modified some testing resources (PETS table and corresponding dimensions) to allow better testing on `LookupDimension`s
 
 -  [Lookup Dimension Serializer](https://github.com/yahoo/fili/pull/31)
     * Created `LookupDimensionToDimensionSpec` serializer for `LookupDimension`
     * Created corresponding tests for `LookupDimensionToDimensionSpec` in `LookupDimensionToDimensionSpecSpec`
 
+
 ### Deprecated:
 
+-  [QueryTimeLookup Functionality Testing](https://github.com/yahoo/fili/pull/34)
+    * Deprecated `KeyValueDimensionLoader`, in favor of `TypeAwareDimensionLoader`
+
 
 ### Removed:
 
 
 ### Changed:
 
+-  [QueryTimeLookup Functionality Testing](https://github.com/yahoo/fili/pull/34)
+    * `AbstractBinderFactory` now uses `TypeAwareDimensionLoader` instead of `KeyValueStoreDimensionLoader`
+    * Modified some testing resources (PETS table and corresponding dimensions) to allow better testing on `LookupDimension`s
+
 - [Reorganizes asynchronous package structure](https://github.com/yahoo/fili/pull/19)
     * The `jobs` package is renamed to `async` and split into the following subpackages:
         - `broadcastchannels` - Everything dealing with broadcast channels

diff --git a/...in/java/com/yahoo/bard/webservice/data/config/dimension/KeyValueStoreDimensionLoader.java b/...in/java/com/yahoo/bard/webservice/data/config/dimension/KeyValueStoreDimensionLoader.java
@@ -12,7 +12,10 @@
 
 /**
  * Load the dimensions along with its keyValueStore and searchProvider.
+ *
+ * @deprecated in favor of TypeAwareDimensionLoader which loads corresponding dimension based on config type
  */
+@Deprecated
 public class KeyValueStoreDimensionLoader implements DimensionLoader {
 
     private Iterable<DimensionConfig> configSource;

diff --git a/.../test/java/com/yahoo/bard/webservice/data/config/dimension/TestLookupDimensionConfig.java b/.../test/java/com/yahoo/bard/webservice/data/config/dimension/TestLookupDimensionConfig.java
@@ -7,7 +7,6 @@
 import com.yahoo.bard.webservice.data.dimension.KeyValueStore;
 import com.yahoo.bard.webservice.data.dimension.SearchProvider;
 
-import java.util.Collections;
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Locale;
@@ -18,7 +17,7 @@
  * Hold all of the Configuration information for the look up dimensions.
  */
 public class TestLookupDimensionConfig extends TestDimensionConfig implements LookupDimensionConfig {
-    private final List<String> namespaces;
+    private List<String> namespaces;
 
     /**
      * Constructor.
@@ -59,7 +58,7 @@ public TestLookupDimensionConfig(
             List<String> namespaces
     ) {
         super(apiName, physicalName, keyValueStore, searchProvider, fields, defaultFields);
-        this.namespaces = Collections.unmodifiableList(namespaces);
+        this.namespaces = namespaces;
     }
 
     @Override