Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metric binding to protected #1033

Merged
merged 2 commits into from
Mar 30, 2020
Merged

Metric binding to protected #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfaa9b5
Update AbstractBinderFactory.java
efronbs Mar 30, 2020
76d4c1c
changelog
efronbs Mar 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ pull request if there was one.
Current
-------
### Fixed:
- [Fix bug where metric binding hook has set to private so it couldn't be overriden](https://github.com/yahoo/fili/pull/1033)
- [Adds missing argument to format string in a rarely used error path in RequestLog](https://github.com/yahoo/fili/pull/1031)
- [Fix bug where some Aggregation model types were incorrectly reporting precision](https://github.com/yahoo/fili/pull/1017)
* CardinalityAggregation, LongMaxAggregation, and LongMinAggregation were incorrectly reporting their precision as
Expand Down
2 changes: 1 addition & 1 deletion fili-core/src/main/java/com/yahoo/bard/webservice/application/AbstractBinderFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,7 +409,7 @@ protected void configure() {
*
* @param binder The binder to bind the generator to.
*/
private void bindMetricGenerator(AbstractBinder binder) {
protected void bindMetricGenerator(AbstractBinder binder) {
List<String> protocols = Collections.emptyList();
TypeLiteral<List<String>> stringListLiteral = new TypeLiteral<List<String>>() { };

Expand Down