Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging in LogBlock uses toString which isn't attractive on AllGranul… #1104

Merged
merged 1 commit into from Oct 28, 2020

Conversation

michael-mclawhorn
Copy link
Contributor

…arity.

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

CHANGELOG.md Outdated
@@ -66,12 +66,6 @@ Current
* Created `LegacyGenerator` as a bridge interface from the existing constructor based api request impls and the factory based value object usage.

### Added:
- [Add ablity to chain ResultSetMappers ](https://github.com/yahoo/fili/issues/1100)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accidently removed?

@michael-mclawhorn michael-mclawhorn force-pushed the iss1102-serialization-of-all-granualrity branch from a3fb932 to 077dfb2 Compare October 28, 2020 15:33
@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_141) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@michael-mclawhorn michael-mclawhorn merged commit 296f39f into master Oct 28, 2020
@michael-mclawhorn michael-mclawhorn deleted the iss1102-serialization-of-all-granualrity branch April 23, 2021 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants