Remove org.json dependency #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like a lot of the code around |
archolewa
approved these changes
Jul 7, 2017
| JSONArray expectedJsonObj1 | ||
| JSONArray expectedJsonObj2 | ||
| JSONArray expectedJsonObj3 | ||
| ObjectMapper mapper = new ObjectMapper() |
There was a problem hiding this comment.
Rather than building an ObjectMapper directly, I would suggest going through the ObjectMappersSuite. The ObjectMappersSuite That way you're using ObjectMappers with the same configuration as we do throughout the rest of the codebase.
kevinhinterlong
force-pushed
the
removeOrgJsonDependency
branch
from
42b0147
to
2c262e9
Compare
|
👍 |
michael-mclawhorn
approved these changes
Jul 10, 2017
kevinhinterlong
added
MERGEABLE
and removed
NEED 1 REVIEW
NEED CHANGES
REVIEWABLE
labels
- All org.json uses have been replaced with jackson equivalent
- Now uses the object mapper configuration used everywhere else in fili-core
kevinhinterlong
force-pushed
the
removeOrgJsonDependency
branch
from
b76b526
to
2d094ae
Compare
- The merge from master should have replaced the previous lines with these but somehow it just removed them
kevinhinterlong
force-pushed
the
removeOrgJsonDependency
branch
from
2d094ae
to
60e766c
Compare
kevinhinterlong
added a commit
to kevinhinterlong/fili
that referenced
this pull request
Jul 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #340