Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dimension metadata to indicate storage strategy #558

Merged
merged 2 commits into from
Oct 31, 2017
Merged

Implement dimension metadata to indicate storage strategy #558

merged 2 commits into from
Oct 31, 2017

Conversation

QubitPi
Copy link
Contributor

@QubitPi QubitPi commented Oct 30, 2017

Address issue #548

michael-mclawhorn
michael-mclawhorn approved these changes Oct 31, 2017
View reviewed changes
Copy link
Contributor

@michael-mclawhorn michael-mclawhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to base storage strategy on the SearchProvider, but that can be done at the loader rather than in the constructor, so this is fine.

@QubitPi
Copy link
Contributor Author

QubitPi commented Oct 31, 2017 •
edited

@michael-mclawhorn Sure. Next time I'll put more attention on SearchProvider to make implementation possibly more optimal

tarrantzhang
tarrantzhang approved these changes Oct 31, 2017
View reviewed changes
Copy link
Collaborator

@tarrantzhang tarrantzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@QubitPi QubitPi merged commit f6d1d19 into master Oct 31, 2017
@QubitPi QubitPi deleted the dimension-storage-strategy branch October 31, 2017 21:11
@QubitPi QubitPi mentioned this pull request Nov 1, 2017
Closed
@QubitPi QubitPi mentioned this pull request Mar 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-mclawhorn michael-mclawhorn michael-mclawhorn approved these changes

@tarrantzhang tarrantzhang tarrantzhang approved these changes

Assignees
No one assigned
Labels
MERGEABLE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@QubitPi @michael-mclawhorn @tarrantzhang