Refactor HttpResponseMaker to allow for building custom ResponseData #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // getVolatileIntervalsWithDefault(responseContext), | ||
| // pagination, | ||
| // bodyLinks | ||
| // ); |
There was a problem hiding this comment.
Obviously you have to remove this to pass review.
michael-mclawhorn
requested changes
Dec 19, 2017
QubitPi
suggested changes
Dec 20, 2017
michael-mclawhorn
approved these changes
Jan 2, 2018
QubitPi
approved these changes
Jan 2, 2018
efronbs
force-pushed
the
refactor-HttpResponseMaker-ResponseData
branch
from
520f2e2
to
8a4f02a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.