Annotate Functional Interface #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QubitPi
force-pushed
the
annotate-functional-interface
branch
from
b667472
to
7124c39
Compare
|
@tarrantzhang Thank you! I've added to them all except for |
tarrantzhang
approved these changes
Jan 30, 2018
cdeszaq
approved these changes
Mar 8, 2018
|
@QubitPi I think this just needs a little bit of manual intervention to resolve the conflicts and it should be ready to merge. |
|
@cdeszaq Thanks for the approval! I'm not able to see where conflicts are. Could you point me to the conflict location? |
QubitPi
force-pushed
the
annotate-functional-interface
branch
from
61ba5ca
to
ee20bdd
Compare
|
@cdeszaq I think all conflicts are resolved 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
@FunctionalInterfaceannotation to all functional interfaces.It is not mandatory to use it, but it is best practice to use it with functional interface to avoid addition of extra methods accidentally. If the interface is annotated with
@FunctionalInterfaceannotation and we try to have more than one abstract method, it throws compiler error.The major benefit of functional interface is that we can use lambda expressions to instantiate them and avoid using bulky anonymous class implementation. Since there is only one abstract function in the functional interfaces, there is no confusion in applying the lambda expression to the method.