Add config to ignore partial/volatile intervals and cache everything in cache V2 #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QubitPi
changed the title
michael-mclawhorn
previously approved these changes
Mar 9, 2018
| @@ -10,6 +10,7 @@ | |||
| @Deprecated DRUID_CACHE("druid_cache_enabled"), | |||
| @Deprecated DRUID_CACHE_V2("druid_cache_v2_enabled"), | |||
| QUERY_SPLIT("query_split_enabled"), | |||
| CACHEABLE_CHECK("cacheable_check"), | |||
There was a problem hiding this comment.
rename to 'CACHE_PARTIAL_DATA'
michael-mclawhorn
requested changes
Mar 9, 2018
michael-mclawhorn
approved these changes
Mar 9, 2018
QubitPi
force-pushed
the
dont-check-cacheable
branch
from
b315780
to
8de0439
Compare
tarrantzhang
reviewed
Mar 9, 2018
| @@ -131,32 +151,96 @@ class CacheV2ResponseProcessorSpec extends Specification { | |||
| 0 * dataCache.set(*_) | |||
| } | |||
|
|
|||
| def "Partial data doesn't cache and then continues"() { | |||
| setup: | |||
| def "When cache_partial_data is turned off, partial data is cached and then continues"() { | |||
There was a problem hiding this comment.
You can rewrite these 6 tests with @Unroll:
@Unroll
def "When cache_partial_data is turned #isOn, #dataType is cached and then continues"() {
setup: "check if volatile data can be cached"
CACHE_PARTIAL_DATA.setOn(isOnBoolean)
when: "we process response"
crp.processResponse(json, groupByQuery, null)
then: "query is checked and volatile data is cached"
methodRunCounts[0] * next.getResponseContext() >> context
methodRunCounts[1] * next.processResponse(json, groupByQuery, null)
methodRunCounts[2] * dataCache.set(*_)
where:
isOn | dataType | isOnBoolean | context | methodRunCounts
"off" | "partial data" | false | createResponseContext([(MISSING_INTERVALS_CONTEXT_KEY.name): intervals]) | [0,1,1]
"on" | "partial data" | true | createResponseContext([(MISSING_INTERVALS_CONTEXT_KEY.name) : nonEmptyIntervals]) | [2,1,0]
"on" | "partial data" | true | createResponseContext([:]) | [2,1,1]
"off" | "volatile data"| false | createResponseContext([(MISSING_INTERVALS_CONTEXT_KEY.name): intervals]) | [0,1,1]
"on" | "volatile data"| true | createResponseContext([(VOLATILE_INTERVALS_CONTEXT_KEY.name) : nonEmptyIntervals])| [2,1,0]
"on" | "volatile data"| true | createResponseContext([:]) | [2,1,1]
}
tarrantzhang
approved these changes
Mar 9, 2018
|
@michael-mclawhorn @tarrantzhang Thank you for the approvals! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.