Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "require('fluxible-app/utils/createStore')" and also "BaseStore"? #28

Closed
protron opened this issue Jan 15, 2015 · 4 comments
Closed

Comments

@protron
Copy link

protron commented Jan 15, 2015

I suggest to improve the way the user has to import the "createStore" and "BaseStore" utilities. Because the current approach seems like we are requiring a "private" file instead of something well documented and ready for use.

I could provide a PR (if you want). My approach would be just updating the "Helper Utilities" section in the README.md and the /index.js to add the following:

module.exports.createStore = require('./utils/createStore');
module.exports.BaseStore = require('./utils/BaseStore');
@mridgway
Copy link
Collaborator

We don't export these utilities in the index.js because it is not required to use these libraries. If we export it in the index.js, then anyone using webpack or browserify would get them bundled with their application even if they didn't use them.

We're considering moving these two utilities to a separate package.

@jedireza
Copy link
Contributor

👍 for moving

@protron
Copy link
Author

protron commented Jan 15, 2015

Oh, I see. I didn't know that about the bundled. Thank you!

@redonkulus
Copy link
Contributor

We have a similar issue in dispatchr to track this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants