refactor: use subset of http-status #27
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #26 by taking a subset of the status codes from http-status which contains a bunch of other unused entries which are contributing to bloat: https://unpkg.com/http-status@1.5.0/lib/index.js
This drops the total size of the package from 22.5 KiB to just 3.2 KiB without changing the message returned for each status code.
This would technically change the functionality if someone passed one of the non-numerical keys that are part of the
http-status
library, though it seems odd to have an error withe.statusCode = '401_CLASS'
- it would become a 500 error after this change.The documentation specifically calls out the status code as being a number so I'm not concerned about it. The docs even specify that the statusCode "Must be greater or equal 400" but I'm keeping the other error codes as well since it's hardly any weight and that very well could be a breaking change for some people.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.