This repository has been archived by the owner on May 23, 2019. It is now read-only.
Fix zeroes not being displayed in formatted strings #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 we have some places we display zero as well, so this will affect us as well. |
|
I ran into this issue on our app too, can a new version be published on npm? |
| @@ -110,6 +110,15 @@ describe('IntlMessageFormat', function () { | |||
|
|
|||
| expect(output).to.equal('My name is Anthony Pipkin.'); | |||
| }); | |||
|
|
|||
| it('should not ignore zero values', function() { | |||
| var mf = new IntlMessageFormat('I am {age} years old.'); | |||
There was a problem hiding this comment.
Why not use {age, number} in something like this?
|
Closing as |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.