startIndex fix for druid subsequent query #718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
This PR aims to fix the misuse of startIndex for subsequent query in MultiEngineQuery.
Currently, if we have greater than 0 startIndex, it will pass to both drivingQuery as well as the subsequent one, which will cause unwanted row drop in druid for the following places:
https://github.com/yahoo/maha/blob/master/druid/src/main/scala/com/yahoo/maha/executor/druid/DruidQueryExecutor.scala#L237
https://github.com/yahoo/maha/blob/master/druid/src/main/scala/com/yahoo/maha/executor/druid/DruidQueryExecutor.scala#L264-L269
This PR modifies the RequestModel for subsequent queries. If this is not ideal, another option is modify the startIndex specific for druid query:
https://github.com/yahoo/maha/blob/master/druid/src/main/scala/com/yahoo/maha/executor/druid/DruidQueryExecutor.scala#L164-L168
For this option we can either check dimdriven-related parameters or check if the previous rowList is empty.