Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Putting a README.md in the mojits/ directory causes mojito to not load #1017

Closed
gotwarlost opened this Issue · 4 comments

3 participants

@gotwarlost
$ touch mojits/README.md
$ ./node_modules/mojito/bin/mojito start --context environment:development
info: (mojito-resource-store): Store initialized
info: (mojito-resource-store): Store initialized

/tmp/ui/node_modules/mojito/lib/app/addons/rs/config.js:149
                            throw new Error("Error parsing file: " + fullPath 
                                  ^
Error: Error parsing file: /tmp/ui/mojits/README.md/definition.json

Not a big deal but a bug all the same.

@gotwarlost

Note how it thinks that README.md is a directory. If this is common code, this bug may have other subtler manifestations.

@caridy
Owner

/ping @drewfish

@drewfish
Owner

Looks like a bug in the resource store.

@drewfish drewfish was assigned
@drewfish
Owner

I think the fix entails added a check in lib/app/autoload/store.server.js _preloadDirMojit() to make sure that the dir argument is actually a directory (and just return if it isn't).

@lzhan lzhan closed this in aba26fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.