This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Added client-side unescape of escaped content. #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applications which were relying on HTML entities in thier configs were still seeing issues with the escape routine. This patch added unescape logic to the util routines, adds unit tests for those routines, and puts unescape logic on the config data passed to the MojitoClient constructor function. This function is only invoked in one place, the deploy.server.js file's initializer block.
|
passed pull job #33 |
|
oops accidentally put plus one a sec ago.. but folks are still verifying secondary failures |
isao
pushed a commit
that referenced
this pull request
Jul 31, 2012
Added client-side unescape of escaped content.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applications which were relying on HTML entities in thier configs were still
seeing issues with the escape routine. This patch added unescape logic to the
util routines, adds unit tests for those routines, and puts unescape logic on
the config data passed to the MojitoClient constructor function. This function
is only invoked in one place, the deploy.server.js file's initializer block.