Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Added support for /robots.txt and fixed JSLint errors #565

Merged
merged 2 commits into from
Oct 12, 2012
Merged

Added support for /robots.txt and fixed JSLint errors #565

merged 2 commits into from
Oct 12, 2012

Conversation

jlecomte
Copy link
Contributor

Eventually, this should be done using new, special routes...

@caridy
Copy link
Contributor

caridy commented Sep 25, 2012

Should mojito be smart enough to generate robots and manifest files?

I do think that we should be able to redefine/force specific files though, so I will give it a +1

@drewfish
Copy link
Contributor

You could instead have a route for /robots.txt that invokes a mojit, but that's probably overkill for most cases.

I'd prefer a solution that allows that to happen, but we can go with this for now, and tweak it later.

@caridy
Copy link
Contributor

caridy commented Sep 26, 2012

Ok, I will merge this, and we can plan for having some sort of npm bundle to add support for robots and manifest that can be plugged into the apps by just adding them as dependencies.

@caridy
Copy link
Contributor

caridy commented Sep 26, 2012

Ops, I just noticed the error msg in travis about the todo flag in jslint, who fails on node 0.8

http://travis-ci.org/#!/yahoo/mojito/jobs/2559216

@mridgway @mojit0 do you know what's going on with this?

@mojit0
Copy link
Contributor

mojit0 commented Sep 26, 2012

@caridy afaik we're using the version in npm and hence the todo flag isn't supported until that package is updated from a jslint version which supports it.

@jlecomte
Copy link
Contributor Author

We should also add support for crossdomain.xml... Caridy, can you add that one line, or do you need a new pull request?

@caridy
Copy link
Contributor

caridy commented Sep 26, 2012

@jlecomte u can commit that line under the same PR, and it will be aggregated automatically once u push to your branch.

@caridy
Copy link
Contributor

caridy commented Sep 27, 2012

Ok, this is ready to be merged. I will hold it until I finish the update of node-jslint pkg to support todo flag, so we can validate the tests and move on.

@rwaldura
Copy link
Contributor

@caridy are we still on hold for this?
Can @lzhan help?

@lzhan
Copy link
Contributor

lzhan commented Oct 12, 2012

@jlecomte is it ok to remove the "todo:true"? I don't see js error from "mojito jslint" command after it is removed.

@lzhan lzhan mentioned this pull request Oct 12, 2012
Merged
@lzhan lzhan merged commit ebccc52 into YahooArchive:develop Oct 12, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants