Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

support for custom version of yui at the app level #721

Closed
wants to merge 1 commit into from

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Nov 8, 2012

  • by using npm i yui@<some-version> in the app folder, at the same level then mojito, it will force mojito to rely on that version of yui.
  • a warning message will be issued to announce the detection of the new yui version.
  • this version will affect server and client.
  • for customization of the client side only for online apps, you can use application.json->yui->config settings instead.

TODO:

  • test this in manhattan
  • add unit test

…the version bundled with mojito for those who wants to live on the edge.
@caridy
Copy link
Contributor Author

caridy commented Nov 8, 2012

/cc @ItsAsbreuk @sdesai

@mojit0
Copy link
Contributor

mojit0 commented Nov 8, 2012

+1

var libfs = require('fs'),
libpath = require('path'),
libvm = require('vm'),
appRoot = process.cwd(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the part that I suspect will fail in Manhattan. In Manhattan the server handles multiple apps, and so doesn't cd to any particular app directory at startup.

@ItsAsbreuk
Copy link

I hope this also involves custom base location at the client side other than used on the client side.
Because situations may exist where clientside loads from a custom comboloader through ssl. The serverside doesn't need to (preferably not).

Marco.

@caridy
Copy link
Contributor Author

caridy commented Nov 18, 2012

@ItsAsbreuk that's already covered with the new yui->config->seed and yui->config->base / comboBase / root, they are not affecting the server side execution, only the client side. I showed an example during my yuiconf presentation, here is the link of the gist:

https://gist.github.com/4070536#file_custom_seed_2.json

@ItsAsbreuk
Copy link

Caridy, you are great!
I haven;t seen your presentation yet. I've started looking at your sheets (http://www.slideshare.net/caridy/yuiconf2012-mojito-for-yui-developers) right now :)

Regards,
Marco.

@drewfish drewfish closed this Nov 28, 2012
@drewfish
Copy link
Contributor

Hi everyone,

The develop-perf branch just went away, and github auto-closed pull requests against it. You'll have to redo this pull request against the develop branch. Sorry about this.

Drew

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants