GraphQL Mock Query Argument Handling #942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkusa
reviewed
Aug 6, 2020
jkusa
reviewed
Aug 6, 2020
|
|
||
| export default class ElideFactsSerializer extends EmberObject implements NaviFactSerializer { | ||
| normalize(payload: AsyncQueryResponse, request: RequestV1): ResponseV1 | undefined { | ||
| const requestTable: string = request.logicalTable.table; | ||
| normalize(payload: AsyncQueryResponse, request: RequestV1 | RequestV2): ResponseV1 | undefined { |
There was a problem hiding this comment.
Can we just assume v2 from now on?
There was a problem hiding this comment.
This is merging onto master not request-v2
| @@ -1,11 +1,25 @@ | |||
| // TODO: Replace any with type supplied by new version of mirage | |||
| import { grains } from './graphql'; | |||
There was a problem hiding this comment.
Can we rebase on this with the new file name?
There was a problem hiding this comment.
The new file names are in the request v2 branch and this is being merged into master
kevinhinterlong
approved these changes
Aug 7, 2020
added 2 commits
August 7, 2020 14:13
jkusa
approved these changes
Aug 7, 2020
|
Moving to a PR to merge into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The elide fact mock is pretty bare bones and can't alter the results based on filters, sorts, or limits in the request.
Proposed Changes
Screenshots
License
I confirm that this contribution is made under an MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.