This repository has been archived by the owner on Jul 15, 2019. It is now read-only.
readWrite branch merged into the master branch #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done: maintain elder and failedelder list TODO: reincarnation, GC, elder broadcast, get using failedelder
TODO: GC, HBase client
TODO: GC, wwRows->WAL, send failedElder at connection start, check elders at TSO query
… HBase initial values
…ing everything in some rows
remove sleep in client start
Conflicts: pom.xml src/main/java/com/yahoo/omid/tso/TSOHandler.java src/main/java/com/yahoo/omid/tso/TSOServer.java
still needs more work
fix a performance bug with read-only transactions, compile nativelib based on the jar file set max number of test messages from int to long
measure forced flushes geometric distribution of requests
| } | ||
|
|
||
| public int hashCode() { | ||
| return (int)getId(); |
There was a problem hiding this comment.
good enough for the Elder class. Also, here quick computation matters more.
There was a problem hiding this comment.
Not good enough for several reasons:
- You are using it in a hashSet, so it is really important to have use a good hashCode()
- Consecutive elders are going to have very close hashcodes
- Big startTimestamps are going to hash to the same value, which is really really bad
- A good hashCode is very fast:
@Override
public int hashCode() {
final int prime = 31;
int result = 1;
result = prime * result + (int) (startTimestamp ^ (startTimestamp >>> 32));
return result;
}
|
Daniel, your comments are applied. |
| return startTimestamp; | ||
| } | ||
| public long getCommitTimestamp() { | ||
| assert(commitTimestamp != -1);//this could happen if it is not set by constructor |
There was a problem hiding this comment.
is this a debugging assertion or something you would want to enforce at runtime?
|
Are you going to address the indentation and readability issues in this merge or do you want to do that afterwards? |
|
Daniel, your comments are applied |
| //if (IsolationLevel.checkForReadWriteConflicts) | ||
| //for (RowKey r: msg.readRows) | ||
| //if (lockedSet.remove(r.index))//unlock only if it's locked | ||
| //sharedState.hashmap.unlock(r.index); |
|
Daniel, your comments are applied. |
| public class ColumnFamilyAndQuantifier { | ||
| protected byte[] family; | ||
| protected byte[] qualifier; | ||
| protected Integer hash = null; |
added 2 commits
May 25, 2012 07:09
francisco-perez-sorrosal
pushed a commit
that referenced
this pull request
May 27, 2015
Set all configuration through program parameters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readWrite branch includes features like serializability as well as high-granularity locks to scale with number of cores in the status oracle. This merge makes these features available to the main users on the master branch.