Include Interface Index As Dimension

yahoo · May 14, 2020 · 1b556c1 · 1b556c1
1 parent 59b0403
commit 1b556c1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/tests/plugins/helpers.py b/tests/plugins/helpers.py
@@ -362,7 +362,7 @@ def test_enrichment_plugin_results(self):
         result = plugin.run(self._plugin_context)
 
         self.assertIsNotNone(result)
-
+        print(result.json())
         result = ordered(json.loads(result.json()))
         expected = ordered(self._expected_results)
 
@@ -417,6 +417,9 @@ def test_basic_operations(self):
 
         plugin = self.plugin_class()
         results = plugin.run(self._plugin_context)
+        print(self._remove_timestamps(results))
+        print()
+
 
         self.assertEqual(ordered(self._expected_results), ordered(self._remove_timestamps(results)))
 

diff --git a/tests/plugins/polling/interface/data/results.json b/tests/plugins/polling/interface/data/results.json
@@ -5,6 +5,10 @@
         "dimension_name": "parent_interface_media_type",
         "dimension_value": "<not set>"
       },
+      {
+        "dimension_name": "interface_index",
+        "dimension_value": "5"
+      },
       {
         "dimension_name": "alias",
         "dimension_value": "Gi0"

diff --git a/yahoo_panoptes/plugins/polling/interface/plugin_polling_device_interface_metrics.py b/yahoo_panoptes/plugins/polling/interface/plugin_polling_device_interface_metrics.py
@@ -67,6 +67,7 @@ def __init__(self):
         self._ifx_table_stats_map = None
 
         self._DIMENSION_MAP = {
+            u'interface_index': lambda x: str(x),
             u'alias': self.get_alias,
             u'media_type': self.get_media_type,
             u'description': self.get_description,
@@ -328,6 +329,7 @@ def _smart_add_dimension(self, method, dimension_name, index):
                                                                                 _DEFAULT_DIMENSION_VALUE))
 
     def get_results(self):
+
         self._polling_status = PanoptesPollingStatus(resource=self.resource,
                                                      execute_frequency=self.execute_frequency,
                                                      logger=self.logger,