Merge pull request #192 from yahoo/update_dimension_filters

PanoptesMetricDimension - Remove Check On Value

tests/test_framework_metrics.py

@@ -216,7 +216,9 @@ def test_panoptes_metric_dimension(self):
         with self.assertRaises(ValueError):
             PanoptesMetricDimension(u'contain$_invalid_character$', u'bar')
         with self.assertRaises(ValueError):
-            PanoptesMetricDimension(u'foo', u'contains_pipe|')
+            PanoptesMetricDimension(u'contains_pipe|', u'foo')
+
+        self.assertEqual(u'|', PanoptesMetricDimension(u'foo', u'|').value)
 
         dimension_one = PanoptesMetricDimension(u'if_alias', u'bar')
 

yahoo_panoptes/framework/metrics.py

@@ -160,6 +160,10 @@ def __eq__(self, other):
 
 
 class PanoptesMetricDimension(object):
+    """
+    Dimension Name Regex: ^[^\d\W]\w*\Z
+    Dimension Value Regex: .+
+    """
     def __init__(self, name, value):
         assert name and isinstance(name, string_types), (
             u'dimension name must be non-empty str or unicode, is type %s' % type(name))
@@ -170,9 +174,6 @@ def __init__(self, name, value):
             raise ValueError(
                     u'dimension name "%s" has to match pattern: (letter|"_") (letter | digit | "_")*' % name)
 
-        if u'|' in value:
-            raise ValueError(u'dimension value "%s" cannot contain |' % value)
-
         self.__data = dict()
 
         self.__data[u'dimension_name'] = name