Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Interface Index As Dimension #181

Merged
merged 4 commits into from Aug 17, 2020
Merged

Conversation

road-cycling
Copy link
Collaborator

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@varunvarma
Copy link
Collaborator

Interface Indexes are ephemeral - they can change after restart of the device or even the SNMP agent on the device.

Some platforms do preserve interface indexes across restarts - and some have a configuration option to preserve these across restarts.

This should be probably be a configurable option per plugin instance.

The other option, which is going to be much more involved, is to expose this only through the Icarus API - which is a point in time view of interfaces.

@coveralls
Copy link

coveralls commented May 14, 2020

Pull Request Test Coverage Report for Build 704

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 92.785%

Totals Coverage Status
Change from base Build 695: 0.002%
Covered Lines: 5633
Relevant Lines: 6071

💛 - Coveralls

@road-cycling road-cycling merged commit 1d7c72b into master Aug 17, 2020
@road-cycling road-cycling deleted the includeIfIdxInterface branch August 17, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants