Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Knob To Forward Ping Requests Through Steamroller #185

Merged
merged 1 commit into from Oct 19, 2020
Merged

Add Knob To Forward Ping Requests Through Steamroller #185

merged 1 commit into from Oct 19, 2020

Conversation

road-cycling
Copy link
Collaborator

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 726

  • 131 of 134 (97.76%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 93.03%
Changes Missing Coverage Covered Lines Changed/Added Lines %
yahoo_panoptes/framework/utilities/ping.py 102 105 97.14%
Files with Coverage Reduction New Missed Lines %
yahoo_panoptes/plugins/polling/utilities/polling_status.py 1 91.01%
Totals Coverage Status
Change from base Build 723: 0.01%
Covered Lines: 5846
Relevant Lines: 6284
💛 - Coveralls

rexfury-of-oath
rexfury-of-oath approved these changes Oct 19, 2020
View reviewed changes
Copy link
Contributor

@rexfury-of-oath rexfury-of-oath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rexfury-of-oath rexfury-of-oath merged commit 626688b into master Oct 19, 2020
@rexfury-of-oath rexfury-of-oath deleted the proxy_ping branch October 19, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rexfury-of-oath rexfury-of-oath rexfury-of-oath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@road-cycling @coveralls @rexfury-of-oath