Fix for grid inside table in IE 10/11 #504

Merged
merged 2 commits into from Dec 5, 2016

Projects

None yet

3 participants

@sgryphon
Contributor

In IE 10 / 11, a grid inside a table does not display (wrap) correctly.

I added an example to the manual test. Load this in IE 10 / 11 (and make the browser small enough so that wrapping is required). IE 10 / 11 doesn't wrap correctly (it works fine outside a table).

The fix uses media query hack to only target IE 10 / 11, and set back to display: block (if inside a table) and rely on the font hack.

I tested in conjunction with pull request #351 to add display: flex for browsers that support it. Note that IE 11 does support display: flex, but has the same issue when inside a table, so also needs the override.

I also tested MS Edge (Spartan), and it renders correctly in the first place; the beta I am using also ignored the -ms media queries and so continued to use flexbox. Interestingly the beta ignored all -ms prefixes but used -webkit prefixes (i.e. with #351 it uses flexbox because of -webkit, not because of -ms).

@sgryphon sgryphon Fix for grid inside table in IE 10/11
f7fa799
@yahoocla

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@sgryphon sgryphon Minor spelling fix, from vsopvsop/patch-1
fa1d053
@KrisSiegel KrisSiegel referenced this pull request Jul 12, 2016
Open

Progress / Roadmap #557

@absalomedia absalomedia added a commit to absalomedia/pure that referenced this pull request Jul 24, 2016
@absalomedia absalomedia Including Pure PR #584, #583, #504, #539 & return basics of multileve…
…l menus
182842f
This was referenced Aug 9, 2016
@redonkulus
Contributor

@sgryphon is it a common use case to have grids inside a table? Not against the PR if it's something that is done often.

@yahoocla

CLA is valid!

@redonkulus
Contributor

Changes look good, thanks!

@redonkulus redonkulus merged commit 6c2aae1 into yahoo:master Dec 5, 2016

2 checks passed

cla/licenses User has a valid Yahoo CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@redonkulus redonkulus added this to the 0.6.1 milestone Dec 5, 2016
@redonkulus
Contributor

@sgryphon released in 0.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment