mocha@3.1.1 breaks build 🚨 #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA is valid! |
|
Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄 |
|
CLA is valid! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
mocha just published its new version 3.1.1.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As mocha is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
GitHub Release
3.1.1 / 2016-10-09
🐛 Bug Fix
done()was called multiple times when it wasn't (@frankleonrose)🔩 Other
.jsfiles ([@boneskull])The new version differs by 36 commits .
5b83625Release v3.1.1138caddrebuild mocha.js [ci skip]db04179update CHANGELOG for v3.1.1 [ci skip]2bb2b9flint the hell out of the javascript; closes #25251c72d5cuse Chrome for browser tests when run on macOS Sierra; closes #2524d62b2b8use semistandardb99e9b3remove errant debug in test/integration/only.spec.jsa40f28dMerge branch 'fix-1417-multiple-done-calls' of https://github.com/frankleonrose/mocha into pull/20599915dfbRelease v3.1.0037cdaebuild dist for v3.1.044a031bCHANGELOG for v3.1.0 [ci skip]8431cb3fix diff output for String objects; closes #2496 (#2499)8bf1f29ensure windows compat with stack trace filter; closes #2502 (#2503)8ccccbafix problems with only/skip in IE7/IE88ef51a5use HTML reporter and default to autoWatch/singleRun modeThere are 36 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? ⚡
greenkeeper upgrade