Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle target="_top" and target="_parent" #169

Merged
merged 1 commit into from Jun 14, 2017

Conversation

@kfay
Copy link
Contributor

kfay commented Jun 13, 2017

@lingyan @redonkulus

This properly handles anchors with target="_top" and target="_blank" when inside an iframe. This should work cross-domain as well. I changed the way the clickHandler unit tests mocked out window and document because jsdom's version of location is read-only.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 13, 2017

Coverage Status

Coverage increased (+0.08%) to 90.625% when pulling bc0b3a6 on kfay:top-and-parent into 94f6faf on yahoo:master.

@lingyan lingyan merged commit 38c4864 into yahoo:master Jun 14, 2017
3 checks passed
3 checks passed
cla/licenses User has a valid Yahoo CLA
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.08%) to 90.625%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.