Bump subscribe-ui-event #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@redonkulus would you guys able to test internally to see if this will break from your side? |
|
I checked this library https://github.com/oliviertassinari/react-event-listener perhaps we could allow a custom binding so that we don't need to maintain a growing map in the code base? |
|
@roderickhsiao possibly when I get more time, but it might be sometime before that happens. |
|
thank you sir |
redonkulus
reviewed
Sep 3, 2018
|
should be good |
|
@redonkulus could you help to release a new version :) |
|
2.7.3 is released now :) |
|
you are the best |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library still using ES5, so I just change the import part without excessive changes
https://github.com/yahoo/subscribe-ui-event/releases/tag/v2.0.0
will let @kaesonho do the honer to upgrader the whole library :)