Fix the wrong i13nNode in the init created event payload #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caa1211
changed the title
caa1211
changed the title
roderickhsiao
approved these changes
Dec 15, 2021
|
This will probably need to be back ported to the 2.x branch if you are using that in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the issue: #426
I thought the best solution is replace the code by 2.x's implementation, but I did not find any ways to get correct
this._i13nNode, it looks like a cached node in createI13Node in 2.x, but because of the implementation changes, it has been put in context in 3.x.So My PR is just passing the i13nNode from context in CoreComponent to the event payload.
If there are any better ideas, please kindly let me know, thanks a lot 馃檪