use subscribe-ui-event #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
CLA is valid! |
kaesonho
force-pushed
the
subscribeuievent
branch
2 times, most recently
from
c89d241
to
f10faa7
Compare
|
First customer 👍 |
| @@ -75,11 +68,11 @@ var Viewport = { | |||
| }, | |||
|
|
|||
| subscribeViewportEvents: function () { | |||
| this.subscribe('scroll', this._detectViewport); | |||
| this.subscription = subscribe('scroll', this._detectViewport, {throttleRate: 500}); | |||
There was a problem hiding this comment.
yes you are right, scrollEnd is what I need, updated,
also update README to create a link to subscribe-ui-event ;)
kaesonho
force-pushed
the
subscribeuievent
branch
from
5ccefbc
to
f758ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@redonkulus @hankhsiao @roderickhsiao
use
subscribe-ui-eventso that we are able to integrate the same event system in a page.