Refactor build and package layout #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericf
force-pushed
the
package-improvements
branch
from
1dc62da
to
3575e9e
Compare
ericf
force-pushed
the
package-improvements
branch
from
3575e9e
to
5f1397f
Compare
This is a major refactor of React Intl's build and npm package layout. Locale data is now package-relative and can more easily be loaded: ```js import enLocaleData from 'react-intl/locale-data/en'; ``` There is now only one copy of these locale data files in the package and they are UMD modules which export the locale data for a language. Rollup is now being used to build a _single-file_ React Intl module for three different targets: - `ReactIntl` global: Browser build with bundled dependencies - CommonJS (`main`): For Node/Browserify/Webpack with `require()`-d dependencies - ES6 (`jsnext:main`): For consumption via `import` with `import`-d dependencies All of the builds are compiled with Babel and bundled into a single module file. Rollup is used to fold all of the internal `src/` modules into one. The difference between `lib/index.js` and `lib/index.es.js` is the latter has everything compiled expect the `import`/`export` statements for React Intl as a whole package. The `.babelrc` files have been moved to closer to the source code which they apply. This allows for test or example code to leverage experimental ECMAScript syntax without leaking it into the main src. These changes should result is a smaller and faster package as all of React Intl's code is folded into a single module scope, and the Babel helpers are only included once (instead of per module file). As well as fixing support for IE8. Fixes formatjs#203 Fixes formatjs#204 Fixes formatjs#275 Fixes formatjs#277
ericf
force-pushed
the
package-improvements
branch
from
5f1397f
to
36bd26e
Compare
ericf
added a commit
that referenced
this pull request
Jan 14, 2016
Refactor build and package layout
|
Sweet! A timeline for the release of a IE8-compatible version? 😄 It'd be great to add it to the current feature we're building |
|
@SimenB blocked by this: rollup/rollup-plugin-babel#34 Writing functional tests right to test the builds which catch the issue in that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor of React Intl's build and npm package layout.
Locale data is now package-relative and can more easily be loaded:
There is now only one copy of these locale data files in the package and they are UMD modules which export the locale data for a language.
Rollup is now being used to build a single-file React Intl module for three different targets:
ReactIntlglobal): Browser build with bundled dependenciesmain): For Node/Browserify/Webpack withrequire()-d dependenciesjsnext:main): For consumption viaimportwithimport-d dependenciesAll of the builds are compiled with Babel and bundled into a single module file. Rollup is used to fold all of the internal
src/modules into one. The difference betweenlib/index.jsandlib/index.es.jsis the latter has everything compiled expect theimport/exportstatements for React Intl as a whole package.The
.babelrcfiles have been moved to closer to the source code which they apply. This allows for test or example code to leverage experimental ECMAScript syntax without leaking it into the main src.These changes should result is a smaller and faster package as all of React Intl's code is folded into a single module scope, and the Babel helpers are only included once (instead of per module file). As well as fixing support for IE8.
Fixes #203
Fixes #204
Fixes #275
Fixes #277