Support array paths with parameter name collisions #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example:
```
path: [
'/a/:foo/:bar',
'/b/:bar'
]
```
Previously the `bar` parameter would only be populated for the `/b/` path.
With this patch it will be populated regardless of which path matches.
|
CLA is valid! |
| // Don't overwrite a previously populated parameter with `undefined`. | ||
| // A route may legitimately have multiple instances of a parameter | ||
| // name if the path was an array. | ||
| if (pathMatches[i+1] !== void 0 || routeParams[self.keys[i].name] === void 0){ |
There was a problem hiding this comment.
minor: instead of void 0, could you use undefined to be consistent with rest of code?
|
@gigabo Thanks for fixing this! Left a minor comment, then we'll be ready to go. |
Per feedback in pull request.
lingyan
added a commit
that referenced
this pull request
Jun 24, 2015
Support array paths with parameter name collisions
|
@gigabo Thanks for your contribution! This fix has been released in https://github.com/yahoo/routr/releases/tag/v0.1.3 |
gigabo
added a commit
to redfin/react-server
that referenced
this pull request
Feb 9, 2016
This picks up [my PR](yahoo/routr#27), and addresses RED-66130.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
Previously the
barparameter would only be populated for the/b/path.With this patch it will be populated regardless of which path matches.
Thanks!