Fix decodeURIComponent of undefined bug #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decodeURIComponent(undefined) returns string 'undefined' which in turn sets all optional parameters that are not present in the url to 'undefined' instead of undefined.
|
CLA is valid! |
1 similar comment
|
CLA is valid! |
|
Seems ok to me 👍 |
|
@gigabo Could you please also help review this? Thanks! |
|
👍 |
|
Makes sense. Nice fix @janus-toendering. 👍 |
|
@janus-toendering thanks! |
|
released in version 2.0.1 |
|
You're welcome. And thank you for routr and friends :-) |
|
thanks @janus-toendering @gigabo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decodeURIComponent(undefined) returns 'undefined' which sets
all optional parameters that are not present in the url to the
string value 'undefined'.