This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
Contrib agent Support for Machine Target Executor #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfinST
force-pushed
the
contrib_agent_impl
branch
from
7c231ab
to
51c8025
Compare
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
=======================================
Coverage 98.68% 98.68%
=======================================
Files 56 56
Lines 2428 2441 +13
Branches 361 363 +2
=======================================
+ Hits 2396 2409 +13
Misses 20 20
Partials 12 12
|
AlfinST
changed the title
AlfinST
force-pushed
the
contrib_agent_impl
branch
from
d6f0482
to
83ae20c
Compare
AlfinST
force-pushed
the
contrib_agent_impl
branch
2 times, most recently
from
7e0a396
to
379cab3
Compare
Comment on lines
328
to
330
| modified_testplan.attack.agents[i].config[ | ||
| "path" | ||
| ] = "./ychaos_ws/{}".format(filename.name) |
There was a problem hiding this comment.
Suggested change
| modified_testplan.attack.agents[i].config[ | |
| "path" | |
| ] = "./ychaos_ws/{}".format(filename.name) | |
| modified_testplan.attack.agents[i].config.path = "./ychaos_ws/{}".format(filename.name) |
r-r-2
reviewed
Jan 13, 2022
r-r-2
previously approved these changes
Jan 13, 2022
AlfinST
force-pushed
the
contrib_agent_impl
branch
from
89d321d
to
57031cc
Compare
r-r-2
approved these changes
Jan 13, 2022
shashankrnr32
approved these changes
Jan 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@yahoo/ychaos-dev
Implementing Contrib agents
Fixes: #93
Checklist
Checklist (Developer)
Prerequisites
Code Analysis
Project related
Autogenerated Files
Pre-Merge Checklist
Checklist (Reviewer 1)
Checklist (Reviewer 2)