This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
=======================================
Coverage 98.89% 98.89%
=======================================
Files 58 58
Lines 2539 2541 +2
Branches 373 373
=======================================
+ Hits 2511 2513 +2
Misses 17 17
Partials 11 11
|
vijaybabu4589
previously approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlfinST can you update the PR check list
vijaybabu4589
approved these changes
Mar 25, 2022
shashankrnr32
approved these changes
Mar 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@yahoo/ychaos-dev
There was a case where the iptables agent failed cause of PATH variable issues when we ssh to host from screwdriver piepeline.
Using the full path so this issue can be resolved.
Checklist
Checklist (Developer)
Prerequisites
Code Analysis
Project related
Autogenerated Files
Pre-Merge Checklist
Checklist (Reviewer 1)
Checklist (Reviewer 2)