Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

using full path for iptables command #132

Merged
merged 5 commits into from
Mar 25, 2022

Conversation

AlfinST
Copy link
Contributor

@AlfinST AlfinST commented Mar 23, 2022

Summary

@yahoo/ychaos-dev

There was a case where the iptables agent failed cause of PATH variable issues when we ssh to host from screwdriver piepeline.
Using the full path so this issue can be resolved.


Checklist

Checklist (Developer)

Prerequisites

  • I have read the contribution guidelines

Code Analysis

  • Covered by Unittests
  • Security warnings ignored (Why?!)

Project related

  • Schema changed and is backward compatible.
  • Introduces a new sub-command for ychaos CLI

Autogenerated Files

  • Auto generated schema

Pre-Merge Checklist

  • All the build jobs are passing

Checklist (Reviewer 1)

  • Reviewed Source Code
  • Reviewed Tests (If applicable)
  • Reviewed Documentation (If applicable)

Checklist (Reviewer 2)

  • Reviewed Source Code
  • Reviewed Tests (If applicable)
  • Reviewed Documentation (If applicable)

@AlfinST AlfinST requested a review from a team as a code owner March 23, 2022 08:18
@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #132 (e41b0ee) into main (48b95ef) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #132   +/-   ##
=======================================
  Coverage   98.89%   98.89%           
=======================================
  Files          58       58           
  Lines        2539     2541    +2     
  Branches      373      373           
=======================================
+ Hits         2511     2513    +2     
  Misses         17       17           
  Partials       11       11           
Impacted Files Coverage Δ
src/ychaos/agents/network/iptables.py 97.01% <100.00%> (+0.04%) ⬆️

@vijaybabu4589 vijaybabu4589 added the enhancement New feature or request label Mar 23, 2022
vijaybabu4589
vijaybabu4589 previously approved these changes Mar 23, 2022
Copy link
Contributor

@vijaybabu4589 vijaybabu4589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlfinST can you update the PR check list

@AlfinST AlfinST merged commit 19b44bc into yahoo:main Mar 25, 2022
@AlfinST AlfinST deleted the useFullPathForiptables branch March 25, 2022 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants