This repository has been archived by the owner on Jan 20, 2024. It is now read-only.
implement SelfTargetExecutor #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please Rebase commits and associate the commits with an Email Address. |
src/ychaos/cli/execute.py
Outdated
| else: | ||
| raise NotImplementedError() | ||
|
|
||
| self._register_machine_target_hooks() |
There was a problem hiding this comment.
This should be part of the individual branch
There was a problem hiding this comment.
could this be changed to _register_target_hooks() and handle both self and machine target hooks there
shashankrnr32
added
enhancement
AlfinST
force-pushed
the
add_SelfTargetExecutor
branch
from
652622f
to
75bb9fd
Compare
AlfinST
commented
Sep 21, 2021
AlfinST
force-pushed
the
add_SelfTargetExecutor
branch
2 times, most recently
from
2527327
to
e4152a2
Compare
AlfinST
force-pushed
the
add_SelfTargetExecutor
branch
2 times, most recently
from
058f1de
to
d4724bd
Compare
AlfinST
changed the title
AlfinST
force-pushed
the
add_SelfTargetExecutor
branch
from
de3e9ec
to
083f8ea
Compare
|
|
||
| if CallbackBase: # pragma: no cover | ||
|
|
||
| class YChaosAnsibleResultCallback(CallbackBase, EventHook): |
There was a problem hiding this comment.
Please add docstrings with some documentation as to what this class does
AlfinST
force-pushed
the
add_SelfTargetExecutor
branch
3 times, most recently
from
a716e85
to
77cc96c
Compare
Codecov Report
@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 98.52% 98.67% +0.15%
==========================================
Files 55 56 +1
Lines 2367 2410 +43
Branches 238 240 +2
==========================================
+ Hits 2332 2378 +46
+ Misses 22 20 -2
+ Partials 13 12 -1
|
shashankrnr32
previously approved these changes
Sep 27, 2021
nafri-irfan96
previously approved these changes
Sep 27, 2021
|
Please hold on to merging this. |
|
Please rebase. Lets merge this on Monday. Thanks for the PR |
AlfinST
force-pushed
the
add_SelfTargetExecutor
branch
from
eb37173
to
e609040
Compare
shashankrnr32
approved these changes
Oct 4, 2021
sushilkar
approved these changes
Oct 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@yahoo/ychaos-dev
Implement SelfTargetExecutor
Fixes: #12
Checklist
Checklist (Developer)
Prerequisites
Code Analysis
Project related
Autogenerated Files
Pre-Merge Checklist
Checklist (Reviewer 1)
Checklist (Reviewer 2)