Skip to content
This repository has been archived by the owner on Jan 20, 2024. It is now read-only.

Add support to SSH common args in TestPlan, make SSH config optional #92

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

shashankrnr32
Copy link
Member

@shashankrnr32 shashankrnr32 commented Nov 24, 2021

Summary

@yahoo/ychaos-dev

  1. Add Support to SSH Common args in testplan (Can also use ENV variable)
  2. SSH config is optional, since all the parameters inside it have defaults

Fixes:

Checklist

Checklist (Developer)

Prerequisites

  • I have read the contribution guidelines

Code Analysis

  • Covered by Unittests
  • Security warnings ignored (Why?!)

Project related

  • Schema changed and is backward compatible.
  • Introduces a new sub-command for ychaos CLI

Autogenerated Files

  • Auto generated schema

Pre-Merge Checklist

  • All the build jobs are passing

Checklist (Reviewer 1)

  • Reviewed Source Code
  • Reviewed Tests (If applicable)
  • Reviewed Documentation (If applicable)

Checklist (Reviewer 2)

  • Reviewed Source Code
  • Reviewed Tests (If applicable)
  • Reviewed Documentation (If applicable)

@shashankrnr32 shashankrnr32 requested a review from a team as a code owner November 24, 2021 06:28
@shashankrnr32 shashankrnr32 self-assigned this Nov 24, 2021
@shashankrnr32 shashankrnr32 added the enhancement New feature or request label Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #92 (39382a0) into main (aa8815c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   98.67%   98.68%           
=======================================
  Files          56       56           
  Lines        2424     2429    +5     
  Branches      242      242           
=======================================
+ Hits         2392     2397    +5     
  Misses         20       20           
  Partials       12       12           
Impacted Files Coverage Δ
src/ychaos/testplan/attack.py 100.00% <100.00%> (ø)

@shashankrnr32 shashankrnr32 merged commit 848baae into yahoo:main Nov 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants