This repository has been archived by the owner on Dec 20, 2022. It is now read-only.
[patch] add go binary version during build time #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Dec 12, 2019
WindzCUHK
force-pushed
the
add-go-binary-version
branch
from
99e82da
to
af45d37
Compare
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 95.7% 89.66% -6.05%
==========================================
Files 10 11 +1
Lines 582 648 +66
==========================================
+ Hits 557 581 +24
- Misses 14 56 +42
Partials 11 11
Continue to review full report at Codecov.
|
Still got the error# github.com/yahoojapan/athenz-client-sidecar
loadinternal: cannot find runtime/cgoTried but not works:
P.S. Set |
docker outputexport TAG=1.2.33333with version # docker build --build-arg APP_VERSION=${TAG} -t yahoojapan/athenz-client-sidecar:latest .
2020-01-28 02:53:30 [INFO]: athenz clientd version -> 1.2.33333 at 20200128-025155 by go1.13.6 linux/amd64
2020-01-28 02:53:30 [INFO]: athenz clientd config version -> v1.0.0without version # docker build -t yahoojapan/athenz-client-sidecar:latest .
2020-01-28 02:55:34 [INFO]: athenz clientd version -> development version at 20200128-025408 by go1.13.6 linux/amd64
2020-01-28 02:55:34 [INFO]: athenz clientd config version -> v1.0.0# run docker
docker run --rm yahoojapan/athenz-client-sidecar:latest -version
# run go
docker run -it --rm golang:1.13-alpine sh |
WindzCUHK
changed the title
kyfujisa
approved these changes
Jan 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue
go binary only print the config file format version currently
format
${APP_VERSION} at ${BUILD_TIME} by ${GO_VERSION}e.g.
1.2.33333 at 20200128-025155 by go1.13.6 linux/amd64TODO