fixes #868 - when allowing duplicates, duplicates are not matched wit…

…h the filtered whitelist
yairEO · Aug 20, 2021 · 8016cf8 · 8016cf8
1 parent aa162f5
commit 8016cf8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/dist/tagify.min.js b/dist/tagify.min.js
@@ -2646,8 +2646,9 @@
 
           var filteredList = this.dropdown.filterListItems.call(this, item[tagTextProp], {
             exact: true
-          }) // also filter out items which have already been matches in previous iterations
-          .filter(filteredItem => !whitelistMatchesValues.includes(filteredItem.value)); // get the best match out of list of possible matches.
+          });
+          if (!this.settings.duplicates) // also filter out items which have already been matches in previous iterations
+            filteredList = filteredList.filter(filteredItem => !whitelistMatchesValues.includes(filteredItem.value)); // get the best match out of list of possible matches.
           // if there was a single item in the filtered list, use that one
 
           var matchObj = filteredList.length > 1 ? this.getWhitelistItem(item[tagTextProp], tagTextProp, filteredList) : filteredList[0];

diff --git a/src/tagify.js b/src/tagify.js
@@ -977,8 +977,11 @@ Tagify.prototype = {
                 // if suggestions are shown, they are already filtered, so it's easier to use them,
                 // because the whitelist might also include items which have already been added
                 var filteredList = this.dropdown.filterListItems.call(this, item[tagTextProp], { exact:true })
+
+
+                if( !this.settings.duplicates )
                     // also filter out items which have already been matches in previous iterations
-                    .filter(filteredItem => !whitelistMatchesValues.includes(filteredItem.value))
+                    filteredList = filteredList.filter(filteredItem => !whitelistMatchesValues.includes(filteredItem.value))
 
                 // get the best match out of list of possible matches.
                 // if there was a single item in the filtered list, use that one