-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholder text only shows when the page first loads #911
Comments
I will fix it promptly (next few days) |
@yairEO I see you pushed a release related to this issue and closed it but I'm on v4.8.1 using mixed mode (textarea, vanilla) and still having a similar problem, just to let you know 😶 When I manually erase all text content (either by selecting all and hitting backspace or just hitting backspace character by character until empty), placeholder is not restored (stays empty forever) and I get this error in console: tagify.min.js:8 Uncaught TypeError: Cannot read properties of null (reading 'nodeType')
at b.onKeydown (tagify.min.js:8) Update: I just tried |
You opened the issue for I will work on a fix for |
I'm not the author of the issue 😆 Sorry, I should've opened a new issue, I didn't understand his issue was specifically for Thanks for the quick reply and for the awesome library by the way! Absolutely life saver! |
Thanks for jumping on this report! There seems to be a bit of confusion as I do not use mix mode so only observed the issue in |
Thank you both for the nice words :) |
Description:
The placeholder text in
select
mode is disappearing after interacting with tagifyAnalysis:
There is CSS applied to the input that sets the placeholder opacity to 1 using the
:empty
psudo selector. When that selector does not match the default styling sets the opacity to 0. When the page first loads the placeholder text is shown. Selecting a tag and then removing it hides the placeholder text because a<br>
child is left behind. This tag is not shown as CSS has set it's display to none. Since it is there at all the parent element is technically not empty and so the override styles no longer apply.This did not occur in 4.7.2 - it only started with 4.8.0 so something in one of these commits is adding that extra br tag.
Demo:
Previous version working
Latest version not working
The text was updated successfully, but these errors were encountered: