Show dropdown on arrow down #333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show dropdown even it is not in select mode.
|
Thanks. I will consider this and might merge it this week. I do see the value in this, just want to make sure it aligns with all the other things nicely because I am aware of a LOT of different things going-on with Tagify (the number of different scenarios is quite large) |
|
Will be a part of |
Merged
yairEO
added a commit
that referenced
this pull request
Dec 12, 2019
- do not add multiple after the last tag, in mixed-mode (happens if initial input value has multiline) - re-wrote "replaceTextWithNode" method completely and renamed it "replaceTextWithNode" - fix bug where unintended mixed-mode prefixes are removed instead of only the one needed - fix bug with mixed-mode dropdown not removed when Tagify de-focus - Changes to "autoComplete" setting. added "rightKey" sub-setting - when dropdown is shown, pressing ESC key should not create a new tag, but only hide the dropdown - improve the auto-comeplete setting with sub-settings for "enter" & "right" keys functionality (issue #103) - on fuzzy-search, only auto-complete the input with terms starts with the typed text - added loader animations to the CSS and "loading" method to Tagify - single-value select mode refactoring - demo page - suggestion list as tags that when clicked add the clicked tag - renamed jQuery event "remove" to "removeTag" #222 - make demo page header fixed to top - all triggered events return the instance's scope (tagify) - add methods to the README (replaceTag) - improved CSS dropdown animations (on show) - Show dropdown suggestions list on arrow down #333 - fixed #267 - Pasted text separated with new line symbol doesn't process correctly - fixed #356 - addTags not working on mix-mode - add boolean property to "this.dropdown" that would tell if the dropdown is shown or not - show suggestions dropdown when editing a tag - add event: "edit:keydown" - new event: "edit:input" - new event: "edit:change" - new event: "edit:start" - added dropdown ability to use css effects when showing - dropdown auto-adjusts its placement if there's no space for it at the bottom, it will flip to be above
|
This is now a part of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show dropdown on the arrow down keypress even it is not in select mode.
I think it makes sense to be able to open the dropdown with arrow down key and not having to click only.