Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Competition quests in progress display tied leaders (and your place if you're behind) #11224

Merged
merged 5 commits into from
Mar 5, 2024

Conversation

SomeTroglodyte
Copy link
Collaborator

This is the reboot of and closes #10739 - so first, if this gets merged, please credit @soggerr not me. All the linting doesn't count.

For this one, it's almost imperative to read the commits separately, as one civInfo->civ rename is a lot of chaff.

  • I did choose different translation templates, so the 10739 screenshots do not quite apply - and i have no save whatsoever on two work-spaces that have active contest-type quests!

  • The toList() below the // Revoke most quest types from the bully in the second commit is a minor bugfix (😉)

  • The removal of the 'shuffle' here is IMHO also a minor bugfix - if you shuffle the payloads and their weights separately (or one and not the other), the "connection" between them is lost, and a weightedRandom meaningless?

But most importantly

A lot is still behind1-ugly readability-wise due to the choice of QuestName as name of that Enum. Can I please rename QuestType to QuestCategory and then QuestName to QuestType? Matching all those parameter names to the changed class names should read a lot better... Will stay a slight discrepancy due to a name being deserialized as String but then converted to a QuestType - but one comment should help with that.

Alternative - redo the Quest concept, make name purely decorative, tie all functionality to new Uniques, with backward compatibility a Much, M·U·C·H bigger task.

Footnotes

  1. You know, as in the clbuttic 'buttbuttination'.

@yairm210 yairm210 merged commit d5fda54 into yairm210:master Mar 5, 2024
4 checks passed
@SomeTroglodyte SomeTroglodyte deleted the CompetitionQuestsDisplay branch March 6, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants