Competition quests in progress display tied leaders (and your place if you're behind) #11224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the reboot of and closes #10739 - so first, if this gets merged, please credit @soggerr not me. All the linting doesn't count.
For this one, it's almost imperative to read the commits separately, as one civInfo->civ rename is a lot of chaff.
I did choose different translation templates, so the 10739 screenshots do not quite apply - and i have no save whatsoever on two work-spaces that have active contest-type quests!
The toList() below the
// Revoke most quest types from the bully
in the second commit is a minor bugfix (😉)The removal of the 'shuffle' here is IMHO also a minor bugfix - if you shuffle the payloads and their weights separately (or one and not the other), the "connection" between them is lost, and a weightedRandom meaningless?
But most importantly
A lot is still behind1-ugly readability-wise due to the choice of
QuestName
as name of that Enum. Can I please renameQuestType
toQuestCategory
and thenQuestName
toQuestType
? Matching all those parameter names to the changed class names should read a lot better... Will stay a slight discrepancy due to aname
being deserialized as String but then converted to a QuestType - but one comment should help with that.Alternative - redo the Quest concept, make name purely decorative, tie all functionality to new Uniques, with backward compatibility a Much, M·U·C·H bigger task.
Footnotes
You know, as in the clbuttic 'buttbuttination'. ↩