Revert Crash caused by Religion Caching

[tuvus]

This PR reverts the Religion Caching commit which causes a bad crash on game load. See #11813.

Briefly looking into it, when the city-religion is initializing it is checking resources on all cities and not all cities have been initialized which causes a problem. Commenting out the two problem lines of code resulted in a different crash. Therefore the best option is to revert this for now.

Since this is a game-breaking level bug for any save with religion enabled I will be patching it immediately.

[tuvus]

Release Patch

[tuvus]

Oops, I didn't realize the patch would merge before the checks passed.

[yairm210]

Thanks!!!

[SomeTroglodyte]

Does this mean a unit test is lacking? Didn't we have one that just loads a game? In that case that game data is too simple.
I found the inverse - canSerializeGame - but wasn't there a big base64gzip const string value someplace in the tests?? Still looking. AH - has its own file. And - that game does indeed have Religion off.

Since we should expect that game to fail loading someday due to removal of backward compatibility stuff - and for that case I'd prefer to see it fail and have a test amendment commit in the same PR that removes the compat code - shall we simply duplicate the test and give the copy a fresh game with everything we can think of?

Let's collect which features (as in has distinct impact on a save json) a new "can load predefined game from string" test should not forget?

• Smallest possible map size, maybe even below the normal limits
• Religion
• Escorting
• Build road to
• A war

• 1 improvement queue

• Some notification history (current test hasn't any)
• Ongoing trades
• Espionage