Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #28 and #31 #32

Closed
wants to merge 2 commits into from
Closed

Fix issue #28 and #31 #32

wants to merge 2 commits into from

Conversation

intfloat
Copy link

Please see my comment on issue #28, the boundary condition is not handled correctly.

For issue #31, @VeliBaba didn't give any description about data, I doubt it is likely to be the same issue.

@intfloat
Copy link
Author

Sorry, my pull request still contains bug, numpy.mean can't be applied directly if last batch has different batch_size.

I'll close this pull request, but original issue remains.

@intfloat intfloat closed this Dec 12, 2015
@VeliBaba
Copy link

Reducing learning rate sometimes helps. For this İ use old version of PDNN. İ change learning rate in the file 'training_state.tmp', and continue. But, it does not always help.

@intfloat
Copy link
Author

I didn't say anything about learning rate.

I mean, this line of code contains bug:

https://github.com/yajiemiao/pdnn/blob/master/learning/sgd.py#L71

which might lead to nan when training, see my comment #28 (comment)

@VeliBaba
Copy link

Yes, I know. I said what I did

On Mon, Dec 14, 2015 at 12:20 PM, Liang Wang notifications@github.com
wrote:

I didn't say anything about learning rate.

I mean, this line of code contains bug:

https://github.com/yajiemiao/pdnn/blob/master/learning/sgd.py#L71

which might lead to nan when training, see my comment #28 (comment)
#28 (comment)


Reply to this email directly or view it on GitHub
#32 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants