[5.6] Better way to shorten the index name. #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this way it is less likely to have an index name conflict
yajra
changed the title
|
Need to review this one further. Have to check also if it will affect when dropping the indexes manually. AFAIK, there is a convention that laravel follows and we have to review it too. |
|
I just tested this with Laravel Passport with known index name issue and seems to work well now. Doing some testing but I think this is good to go. ❤️ |
|
This PR will also fix the following issues: |
This was referenced Feb 16, 2018
Closed
|
That's good to hear. Thanks 😃 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this way it is less likely to have an index name conflict