Multi db access #1437
Open
Multi db access #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxndr-w
reviewed
Apr 2, 2024
dgrothaus-mc
force-pushed
the
multi_db_access
branch
from
2d977c5
to
a5cc06b
Compare
Mirror the PHP and Redaxo core requirements from package.yml to composer.json.
Don't throw an exception when no related table or field is set.
Let yform track the db_id of a table.
Allow to set the database id for yform by passing the parameter $param['db_id'] to the constructor or by calling the method `setDatabaseId()`
Use the db_id from yform. Pass the db_id to rex_sql calls and add a getter to get the database id for managed tables.
All calls that are made by classes using yform are now aware of db_id and use the proper ID when querying the database.
Editing and migrating tables make use of db_id.
dgrothaus-mc
force-pushed
the
multi_db_access
branch
from
a5cc06b
to
d5e4a93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ich habe den bereits vorhandenen PR #1147 aufgegriffen und sowohl yform als auch den Table Manager entsprechend angepasst. Migrieren und Editieren von Daten funktioniert soweit stabil. Die gemachten Änderungen sind intern jetzt drei Wochen lang in einem Projekt getestet worden.
So lange in der Redaxo
config.ymlnur eine Datenbankverbindung eingerichtet ist, ändert sich weder etwas am Verhalten noch am Aussehen. Die zusätzlichen Felder und Funktionen werden erst dann sichtbar, wenn mehr als eine Datenbankverbindung eingerichtet ist.