Assorted cleanup

[waldyrious]

I decided to re-submit #9 to prevent that work from being lost, but I started doing some cleanup in the meantime, so I decided to submit them first. That way, the doubleTurn PR will be clean.

[coveralls]

Coverage decreased (-38.5%) to 61.538% when pulling 2f2708d on waldyrious:cleanup into b5a8e73 on yakir12:master.

[coveralls]

Coverage decreased (-38.5%) to 61.538% when pulling 2f2708d on waldyrious:cleanup into b5a8e73 on yakir12:master.

[yakir12]

This is fantastic, thank you!
I don't quite understand why the coverage decreased by ~40%...?

[waldyrious]

Neither do I :/ the lines marked as uncovered were the ones where I changed the variable names, but I see no reason why that would make the coverage start failing...

[yakir12]

Can you run test with coverage on your branch and see if the relevant lines are getting hit? They really should, if not, something really weird is going on..

[waldyrious]

Sure, how do I do that? (Sorry, I haven't been actively developing Julia in a while...)

[yakir12]

run:

Pkg.test("UnitfulAngles", coverage=true)

and in the source directory of the package (joinpath(Pkg.dir("UnitfulAngles"), "src")) you should fine a file with a cov extension (e.g. UnitfulAngles.jl.9683.cov). Look in it to see if those lines are being hit.

[waldyrious]

Thanks for the detailed instructions :) here's the output: https://gist.github.com/waldyrious/d5ea5dfba5e1e172b4e41b79f483296c

[yakir12]

Right. Those lines are getting tested just fine. This was some weird bug with coveralls...

[waldyrious]

Thanks. I'll do the #9 re-submission PR next week.